Skip to content

llvmPackages.compiler-rt: enable libclang_rt.profile-....a build#218799

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:llvmPackages.compiler-rt-profile-musl
Mar 10, 2023
Merged

llvmPackages.compiler-rt: enable libclang_rt.profile-....a build#218799
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:llvmPackages.compiler-rt-profile-musl

Conversation

@alyssais
Copy link
Copy Markdown
Member

Description of changes

Port of 94cad6e ("llvm 14 compiler-rt: enable libclang_rt.profile-....a build").

Built all except LLVM 7, which doesn't build for unrelated reasons.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Port of 94cad6e ("llvm 14 compiler-rt: enable
libclang_rt.profile-....a build").
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 28, 2023
@alyssais alyssais added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 28, 2023
@alyssais
Copy link
Copy Markdown
Member Author

alyssais commented Mar 2, 2023

Try again for a transient Darwin failure:

@ofborg build llvmPackages.compiler-rt

@rrbutani rrbutani added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 6, 2023
@alyssais
Copy link
Copy Markdown
Member Author

Try again for Nix bug on Darwin:

@ofborg build llvmPackages.compiler-rt

@alyssais alyssais merged commit 0fd04a5 into NixOS:staging Mar 10, 2023
@alyssais alyssais deleted the llvmPackages.compiler-rt-profile-musl branch March 10, 2023 12:57
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants