Skip to content

clang_15: mark hardeningUnsupportedFlags fortify3#218676

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:clang_15-fortify3
Feb 28, 2023
Merged

clang_15: mark hardeningUnsupportedFlags fortify3#218676
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:clang_15-fortify3

Conversation

@alyssais
Copy link
Copy Markdown
Member

@alyssais alyssais commented Feb 27, 2023

Description of changes

Port of 74ea4fe ("llvm*Packages.clang: mark hardeningUnsupportedFlags fortify3").

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais
clang_15: mark hardeningUnsupportedFlags fortify3
8c65972 
Port of 74ea4fe ("llvm*Packages.clang: mark
hardeningUnsupportedFlags fortify3").
@alyssais alyssais requested review from risicle and rrbutani February 27, 2023 20:55
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 27, 2023
rrbutani
rrbutani approved these changes Feb 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rrbutani rrbutani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alyssais! I totally missed #212498

I didn't realize there are already so many clang_15 rdeps 😕; is this okay to target master?

@alyssais
Copy link
Copy Markdown
Member Author

alyssais commented Feb 28, 2023

I didn't realize there are already so many clang_15 rdeps confused; is this okay to target master?

It is not. I'll retarget it.

@alyssais alyssais changed the base branch from master to staging February 28, 2023 00:07
@alyssais alyssais merged commit ed209e6 into NixOS:staging Feb 28, 2023
@alyssais alyssais deleted the clang_15-fortify3 branch February 28, 2023 22:18
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle risicle approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

+1 more reviewer

@rrbutani rrbutani rrbutani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alyssais @risicle @rrbutani