Skip to content

librem: use cmake for configurePhase#218520

Merged
7c6f434c merged 2 commits intomasterfrom
unknown repository
Mar 6, 2023
Merged

librem: use cmake for configurePhase#218520
7c6f434c merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 26, 2023

Description of changes

Although librem is a cmake-based project, our expression for this library does not currently use cmake for the configurePhase. This commit causes it to do so.

This is necessary to get downstream libre and baresip to cross-compile.

Incorporates:

Things done
  • Built on platform(s)
    • aarch64-linux (cross from x86_64-linux)

Adam Joseph added 2 commits February 26, 2023 14:57
Although libre is a cmake-based project, our expression for this
library does not currently use cmake for the configurePhase.  This
commit causes it to do so.

This is necessary to get downstream libre and baresip to cross-compile.
Although librem is a cmake-based project, our expression for this
library does not currently use cmake for the configurePhase.  This
commit causes it to do so.

This is necessary to get downstream libre and baresip to cross-compile.
@ofborg ofborg bot requested review from 7c6f434c and elohmeier February 26, 2023 23:19
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 26, 2023
@7c6f434c 7c6f434c merged commit c2354a6 into NixOS:master Mar 6, 2023
@ghost ghost deleted the pr/librem/cross branch March 7, 2023 10:27
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 16, 2023

@ofborg build baresip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant