spandsp: refactor#218480
Merged
Conversation
1 task
misuzu
approved these changes
Feb 27, 2023
Contributor
misuzu
left a comment
There was a problem hiding this comment.
LGTM! This should probably go to the staging though
misuzu
approved these changes
Mar 7, 2023
Member
|
Wait, it includes the changes, but not the commits? I merged in the wrong order, I guess, but I thought it would work if this PR includes those? |
The `spandsp` derivation has the clauses in the wrong order (e.g. `makeFlags` before `configureFlags`) which makes it hard to understand. This commit fixes the clause order, factors out `common.nix` from the two versions of spandsp, and also tries to normalize the coding style.
Author
#218477 got some suggested changes which I forgot to backport into this PR. It's rebased now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes (to avoid merge conflict):
Description of changes
The
spandspderivation has the clauses in the wrong order (e.g.makeFlagsbeforeconfigureFlags) which makes it hard to understand.This commit fixes the clause order, factors out
common.nixfrom the two versions of spandsp, and also tries to normalize the coding style.CC: @SuperSandro2000 for review
Things done