python310Packages.bokeh: Build from source & enable tests#215406
Closed
mweinelt wants to merge 4 commits intoNixOS:masterfrom
Closed
python310Packages.bokeh: Build from source & enable tests#215406mweinelt wants to merge 4 commits intoNixOS:masterfrom
mweinelt wants to merge 4 commits intoNixOS:masterfrom
Conversation
Member
|
Something similar would be nice for |
mweinelt
commented
Feb 9, 2023
Member
Author
No doubt about that. These changes did cost me some time and energy already, so it's not in the cards for now. |
Member
Yeah, this looks like a lot of work. I'd hope that panel is set up somewhat similarly but I totally understand that you don't feel like tackling that now. |
b489ae3 to
400ad68
Compare
Member
|
Result of 3 packages marked as broken and skipped:
16 packages failed to build:
2 packages built:
|
Member
|
Result of 7 packages marked as broken and skipped:
10 packages failed to build:
4 packages built:
|
Member
|
Result of 7 packages marked as broken and skipped:
12 packages failed to build:
2 packages built:
|
Member
|
Result of 3 packages marked as broken and skipped:
11 packages failed to build:
7 packages built:
|
Member
Author
|
Panel isn't compatible with bokeh 3.0 yet. |
4 tasks
Member
Author
|
Panel 1.0.0 requries bokeh 3.1.1. Rebased and debugg bokeh build and working on panel build. |
431ecbe to
e6a40a5
Compare
3426245 to
85a607e
Compare
0a94699 to
8f2bac0
Compare
https://docs.bokeh.org/en/latest/docs/releases.html#release-3-2-0 Changes the build to a source build and enables tests. To enable the tests we have to fetch the sources from Git, which in turn requires us to build the static files from source. Bokeh uses setuptools-git-versioning, which has no version override, so we also fix the broken fallback version in the package metadata. We skip sampledata tests, because that would require an additional download, and we skip selenium tests because they are crashing with chromium/chromedriver and getting out of sync with geckodriver/firefox.
https://github.com/holoviz/panel/releases/tag/v1.0.0 https://github.com/holoviz/panel/releases/tag/v1.0.1 https://github.com/holoviz/panel/releases/tag/v1.0.2 https://github.com/holoviz/panel/releases/tag/v1.0.3 https://github.com/holoviz/panel/releases/tag/v1.0.4 https://github.com/holoviz/panel/releases/tag/v1.1.0 https://github.com/holoviz/panel/releases/tag/v1.1.1
python310Packages.bokeh: 2.4.3 -> 3.2.1 https://docs.bokeh.org/en/latest/docs/releases.html#release-3-2-1 Changes the build to a source build and enables tests. To enable the tests we have to fetch the sources from Git, which in turn requires us to build the static files from source. Bokeh uses setuptools-git-versioning, which has no version override, so we also fix the broken fallback version in the package metadata. We skip sampledata tests, because that would require an additional download, and we skip selenium tests because they are crashing with chromium/chromedriver and getting out of sync with geckodriver/firefox.
Member
|
Tests are enabled in #252993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enable the tests we have to fetch the sources from Git, which in turn requires us to build the static files from source.
Bokeh uses setuptools-git-versioning, which has no version override, so we also fix the broken fallback version in the package metadata.
Still some failing tests towards and each iteration takes 10-12 minutes and it seems like at some point the selenium stuff just breaks down.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes