Skip to content

openjpeg: move jpylizer to nativeCheckInputs#214789

Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom
alyssais:openjpeg-bsd
Feb 5, 2023
Merged

openjpeg: move jpylizer to nativeCheckInputs#214789
Ericson2314 merged 1 commit intoNixOS:stagingfrom
alyssais:openjpeg-bsd

Conversation

@alyssais
Copy link
Copy Markdown
Member

@alyssais alyssais commented Feb 5, 2023

Description of changes

This is useful when cross-compiling to platforms that we can't build Python for (and also just more semantically correct).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@alyssais
openjpeg: move jpylizer to nativeCheckInputs
3404d6b 
This is useful when cross-compiling to platforms that we can't build
Python for (and also just more semantically correct).
@alyssais alyssais added 6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform labels Feb 5, 2023
@alyssais alyssais requested a review from Ericson2314 February 5, 2023 17:07
@ofborg ofborg bot requested a review from codyopel February 5, 2023 18:03
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 5, 2023
@Ericson2314 Ericson2314 merged commit 6977491 into NixOS:staging Feb 5, 2023
@trofi
Copy link
Copy Markdown
Contributor

trofi commented Feb 5, 2023

Bisect says 3404d6b openjpeg: move jpylizer to nativeCheckInputs broke openjpeg tests in staging as:

$ nix build -f. openjpeg -L
...
openjpeg> running testsable to find executable: /build/source/build/build/jpylyzer
...
openjpeg>     ..................................................  Size: 799K
openjpeg>     ............................................. Size of output: 845K
openjpeg> Unable to find executable: /build/source/build/build/jpylyzer
openjpeg> Unable to find executable: /build/source/build/build/jpylyzer
...

@alyssais
Copy link
Copy Markdown
Member Author

alyssais commented Feb 5, 2023 •
edited
Loading

Ugh, what? I'm sure I tested that, although I rebased so maybe something changed.

Edit: shouldn't have been that sure. I had indeed forgotten to test that.

@alyssais
Copy link
Copy Markdown
Member Author

alyssais commented Feb 5, 2023

Fix: #214824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@codyopel codyopel Awaiting requested review from codyopel

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alyssais @trofi @Ericson2314