Skip to content

udev: point to systemdMinimal all the time#212975

Closed
SuperSandro2000 wants to merge 1 commit intoNixOS:stagingfrom
SuperSandro2000:udev-systemdMinimal
Closed

udev: point to systemdMinimal all the time#212975
SuperSandro2000 wants to merge 1 commit intoNixOS:stagingfrom
SuperSandro2000:udev-systemdMinimal

Conversation

@SuperSandro2000
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 commented Jan 27, 2023 •
edited
Loading

Description of changes

resolve TODO

    # TODO: remove once `udev` is `systemdMinimal` everywhere.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 27, 2023
Merged
13 tasks
Shawn8901
Shawn8901 reviewed Jan 27, 2023
View reviewed changes
@SuperSandro2000 SuperSandro2000 force-pushed the udev-systemdMinimal branch 2 times, most recently from 7b69c91 to 5311897 Compare February 7, 2023 00:44
mweinelt
mweinelt requested changes Feb 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a rationale.

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Feb 7, 2023

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 7, 2023
@SuperSandro2000
Copy link
Copy Markdown
Member Author

SuperSandro2000 commented Feb 7, 2023

added a rational

@alyssais alyssais requested a review from kloenk May 19, 2023 18:13
@kloenk
Copy link
Copy Markdown
Member

kloenk commented May 20, 2023

Don't have anything to test right now. But from the change seems reasonable

@SuperSandro2000
udev: point to systemdMinimal all the time
b1fe31a 
This resolved the following TODO in code:
TODO: remove once `udev` is `systemdMinimal` everywhere.
@SuperSandro2000
Copy link
Copy Markdown
Member Author

SuperSandro2000 commented May 24, 2023

Rebased this to resolve the merge conflict.

@ofborg build libfido2 libusb1 lvm2

@SuperSandro2000
Copy link
Copy Markdown
Member Author

SuperSandro2000 commented Jan 14, 2024

already done in #261798

@SuperSandro2000 SuperSandro2000 deleted the udev-systemdMinimal branch January 14, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@kloenk kloenk Awaiting requested review from kloenk

1 more reviewer

@Shawn8901 Shawn8901 Shawn8901 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SuperSandro2000 @mweinelt @kloenk @Shawn8901