python310Packages.aiohttp: add missing build inputs: setuptools, wheel#212602
Conversation
Author
|
Let me know if this should go to staging instead. It isn't urgent. |
Member
|
Please share the full trace. It is not obvious here where it fails. I think it fails during a test and not the build but cannot be sure from this. |
Author
|
Member
|
Thanks. Checking the trace, it seems to fail during wheel building. Looking at the expression, it seems the build system is not added. It does manage to get access to it via the runtime dependencies ( You can add instead of your current fix nativeBuildInputs = [
setuptools
wheel
];to solve this. Also please follow the contribution guidelines when it comes to the commit title. |
dotlambda
requested changes
Jan 26, 2023
Member
dotlambda
left a comment
There was a problem hiding this comment.
Also please follow the contribution guidelines when it comes to the commit title.
See PR title.
Member
There was a problem hiding this comment.
@FRidh Why wheel? It's not specified in upstream's pyproject.toml.
Member
There was a problem hiding this comment.
The wheel package is always needed to make a wheel. Maybe we get away with it because pip that we instruct to build the wheel brings it in. I don't know anymore.
dotlambda
requested changes
Jan 26, 2023
Builds of aiohttpd have been failing on powerpc64le since 4553e62 with: ``` python3.10-aiohttp> File "/nix/store/mhw4rs4xb20acvn55iw5i5k5rhaqidnq-python3-3.10.9/lib/python3.10/importlib/__init__.py", line 126, in import_module python3.10-aiohttp> return _bootstrap._gcd_import(name[level:], package, level) python3.10-aiohttp> File "<frozen importlib._bootstrap>", line 1050, in _gcd_import python3.10-aiohttp> File "<frozen importlib._bootstrap>", line 1027, in _find_and_load python3.10-aiohttp> File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked python3.10-aiohttp> File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed python3.10-aiohttp> File "<frozen importlib._bootstrap>", line 1050, in _gcd_import python3.10-aiohttp> File "<frozen importlib._bootstrap>", line 1027, in _find_and_load python3.10-aiohttp> File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked python3.10-aiohttp> ModuleNotFoundError: No module named 'setuptools' python3.10-aiohttp> note: keeping build directory '/nix/tmp/nix-build-python3.10-aiohttp-3.8.3.drv-5' ``` This commit adds `setuptools` and `wheel` as `nativeBuildInputs` to fix this.
lopsided98
reviewed
Feb 7, 2023
Contributor
lopsided98
left a comment
There was a problem hiding this comment.
I confirmed that this fixes cross-compiling to armv6l-linux. The build still succeeds without wheel, but I don't know why it should or shouldn't be included.
Author
|
This can wait until after ZHF. |
FRidh
approved these changes
Apr 24, 2023
Member
FRidh
left a comment
There was a problem hiding this comment.
Not tested but I don't see any reason why this would break anything.
12 tasks
Member
|
Fixed with #247310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Builds of aiohttpd have been failing on powerpc64le since 4553e62 with:
This commit adds
python3Packages.setuptoolsas apropagatedBuildInput, which many other python packages seem to do. It fixes the build. I don't know much python, so if there is a better/preferred way to address this please let me know.Things done