matrix-synapse,mautrix-facebook: fix runtime inclusion of python3 systemd#212391
Merged
K900 merged 1 commit intoNixOS:masterfrom Jan 24, 2023
Merged
matrix-synapse,mautrix-facebook: fix runtime inclusion of python3 systemd#212391K900 merged 1 commit intoNixOS:masterfrom
K900 merged 1 commit intoNixOS:masterfrom
Conversation
…temd NixOS#192197 broke these packages by adding systemd as a dependency. This meant that the included package was no longer the python3 systemd package, but the general systemd derivation. This broke the packages at runtime. This PR fixes that.
Member
Author
|
@ofborg test matrix-synapse |
Member
|
I am wondering myself why this easy to spot mistake was not caught in review. |
2 tasks
|
This was my fault, I screwed up. Thank you for cleaning up the mess.
Because it's not easy to spot. The But crapping on reviewers here is not cool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
#192197 broke these packages by adding systemd as a dependency. This meant that the included package was no longer the python3 systemd package, but the general systemd derivation. This broke the packages at runtime. This PR fixes that.
I also checked all other derivations touched by #192197, but these were the only were the systemd dependency was added erroneously.
Things done
Deployed this to my server and checked that it worked for matrix-synapse. I don't run mautrix-facebook, so I couldn't verify that.
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes