Skip to content

nix: if isStatic && atLeast210 then --enable-embedded-sandbox-shell#212304

Merged
Artturin merged 1 commit intomasterfrom
unknown repository
Jan 28, 2023
Merged

nix: if isStatic && atLeast210 then --enable-embedded-sandbox-shell#212304
Artturin merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 23, 2023

Description of changes

This commit enables the embedded sandbox shell for static builds of nix>=2.10.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This commit enables the embedded sandbox shell for static builds of nix>=2.10.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 23, 2023
@Artturin Artturin mentioned this pull request Jan 24, 2023
13 tasks
@Artturin
Copy link
Copy Markdown
Member

@ofborg build nixStatic

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 28, 2023

@ofborg build pkgsCross.powernv.nixStatic
@ofborg build pkgsCross.mips64el-linux-gnuabi64.nixStatic

@Artturin Artturin merged commit d6d1b8b into NixOS:master Jan 28, 2023
@ghost ghost deleted the pr/nix/enable-embedded-sandbox-shell branch January 28, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant