Skip to content

build-rust-crate: handle ILP32 platforms correctly#212303

Merged
superherointj merged 1 commit intomasterfrom
unknown repository
Feb 1, 2023
Merged

build-rust-crate: handle ILP32 platforms correctly#212303
superherointj merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 23, 2023

Description of changes

This commit corrects the value of CARGO_CFG_TARGET_POINTER_WIDTH for ILP32 machines like the Apple Watch and mips64n32.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • powerpc64le-linux
  • Fits CONTRIBUTING.md.

This commit corrects the value of `CARGO_CFG_TARGET_POINTER_WIDTH`
for ILP32 machines like the Apple Watch and mips64n32.
@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Jan 23, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 23, 2023
@ghost ghost marked this pull request as ready for review January 23, 2023 20:57
@hugosenari
Copy link
Copy Markdown

I have no experience here, but maybe this change should be in https://github.com/NixOS/nixpkgs/blob/master/lib/systems/parse.nix 🤔

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 28, 2023

I have no experience here, but maybe this change should be in https://github.com/NixOS/nixpkgs/blob/master/lib/systems/parse.nix thinking

In the long run I would like to eliminate platform.cpu.bits and replace it with platform.cpu.bits.pointer and platform.cpu.bits.arithmetic, to force users to think about which one they mean.

But that is a mammoth undertaking. And it is going to cost me a lot of karma.

@hugosenari
Copy link
Copy Markdown

Liked your idea, any place where we can suggest that?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 31, 2023

Liked your idea, any place where we can suggest that?

https://github.com/NixOS/nixpkgs/pulls

@hugosenari
Copy link
Copy Markdown

Liked your idea, any place where we can suggest that?

https://github.com/NixOS/nixpkgs/pulls

I think we could discuss that with architecture team before any PR, not sure if is a case for RFC.
Unless you're really motivated to write a pull request first.

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 1, 2023
@superherointj superherointj merged commit bc1b930 into NixOS:master Feb 1, 2023
@ghost ghost deleted the pr/build-rust-crate/ilp32 branch February 12, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants