libunistring: enableParallelChecking = false#211885
Merged
Conversation
OPNA2608
reviewed
Jan 23, 2023
enableParallelBuilding was disabled on 2018-09-09 in 4efd405 with a comment describing the test failures it caused. doCheck was disabled afterward, on 2019-08-04 in c170582. Since parallelism bug appears to be in the tests, let's enable parallel building but disable enableParallelChecking. Thanks to @OPNA2608 for mentioning enableParallelChecking; which I didn't know about before writing the first draft of this commit.
trofi
approved these changes
Jan 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
enableParallelBuilding was disabled on 2018-09-09 in 4efd405 with a comment describing the test failures it caused.
doCheck was disabled afterward, on 2019-08-04 in c170582.
Since parallelism bug appears to be in the tests, let's disable parallel checking.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage