pdfstudio: remove libgccjit dependency#211334
Merged
Conversation
I don't think pdfstudio depends on libgccjit. If it did, that would
be a license violation. Unlike the other libraries in gcc,
libgccjit is licensed GPLv3 with no exceptions, since libgccjit
contains the entire compiler.
I wasn't able to build pdfstudio2022 prior to this PR due to openjdk
breakage. However I did download and extract the `.deb` used, and
ran this command, which produced no outputs:
```
find . -name \*.so -exec ldd {} \; | grep libgccjit
```
Maybe somebody confused `libgccjit` with (may it rest in peace)
`libgcj`?
4 tasks
wegank
reviewed
Jan 24, 2023
wegank
reviewed
Jan 24, 2023
Member
|
@ofborg build pdfstudio2021 pdfstudio2022 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I don't think pdfstudio depends on libgccjit. If it did, that would be a license violation. Unlike the other libraries in gcc, libgccjit is licensed GPLv3 with no exceptions, since libgccjit contains the entire compiler. PDF Studio is closed source.
I wasn't able to build pdfstudio2022 prior to this PR due to openjdk breakage (Edit: appears to be this). However I did download and extract the
.debused, and ran this command, which produced no outputs:Maybe somebody confused
libgccjitwith (may it rest in peace)libgcj?Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes