Skip to content

llvmPackages_git: fix cross eval#211225

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
alyssais:llvmPackages_git-cross
Jan 17, 2023
Merged

llvmPackages_git: fix cross eval#211225
Ericson2314 merged 1 commit intoNixOS:masterfrom
alyssais:llvmPackages_git-cross

Conversation

@alyssais
Copy link
Copy Markdown
Member

Description of changes

0c9716a ("llvmPackages: Make sure we can attempt to cross-compile the tools") was not applied to llvmPackages_git, presumably because its definition is hidden away in aliases.nix.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

0c9716a ("llvmPackages: Make sure we can attempt to cross-compile the tools")
was not applied to llvmPackages_git, presumably because its definition
is hidden away in aliases.nix.
@alyssais alyssais requested a review from Ericson2314 January 17, 2023 11:29
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 17, 2023
@Ericson2314
Copy link
Copy Markdown
Member

Oops! Thanks for fixing my mistake!

@Ericson2314 Ericson2314 merged commit 57ec2d4 into NixOS:master Jan 17, 2023
@alyssais alyssais deleted the llvmPackages_git-cross branch January 17, 2023 19:32
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants