Skip to content

ath9k-htc-blobless-firmware: @SuperSandro2000's suggestions#210416

Closed
ghost wants to merge 11 commits intomasterfrom
unknown repository
Closed

ath9k-htc-blobless-firmware: @SuperSandro2000's suggestions#210416
ghost wants to merge 11 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 12, 2023

Description of changes

#208685 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • powerpc64le-linux
    • aarch64-linux
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Jan 12, 2023
5 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 12, 2023
@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 13, 2023

Okay, @SuperSandro2000, I think I have implemented five of your nine comments. Regarding the remaining four:

  • For your last two comments I need some clarification before proceeding
  • Your third comment asked why I had two update attributes; if my explanation is satisfactory please resolve the issue. If not, please explain further.
  • Regarding your sixth comment, I have explained the situation here.

@ghost ghost marked this pull request as ready for review January 13, 2023 13:43
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 13, 2023
@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 13, 2023

Note that this PR also includes one additional tiny change: the unstable package changed from:

pname = "ath9k-htc-blobless-firmware";
version = "unstable-2022-05-22";

to

pname = "ath9k-htc-blobless-firmware-unstable";
version = "2022-05-22";

This made the logic slightly simpler. If it is a problem I can switch back.

@ghost ghost marked this pull request as draft April 24, 2023 03:14
@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the ath9k-htc-blobless-fixes branch October 22, 2023 07:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants