Skip to content

[next] rustPlatform.buildRustPackage: fix cross compiling auditable packages#210394

Merged
figsoda merged 1 commit intoNixOS:staging-nextfrom
figsoda:cross
Jan 12, 2023
Merged

[next] rustPlatform.buildRustPackage: fix cross compiling auditable packages#210394
figsoda merged 1 commit intoNixOS:staging-nextfrom
figsoda:cross

Conversation

@figsoda
Copy link
Copy Markdown
Member

@figsoda figsoda commented Jan 12, 2023 •
edited
Loading

Description of changes

moves cargo-auditable to rustPlatform

nix-build -A pkgsCross.aarch64-multiplatform.ripgrep now works

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested review from LnL7, Mic92 and zowoq as code owners January 12, 2023 17:25
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 12, 2023
@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Jan 12, 2023
This was referenced Jan 12, 2023
Merged
Merged
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 12, 2023
@Mindavi
Copy link
Copy Markdown
Contributor

Mindavi commented Jan 12, 2023

With no rebuilds it's quite suitable for staging-next. Thanks a lot for quickly tackling this! ✨

Mindavi
Mindavi approved these changes Jan 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM but hopefully someone else has a better idea how to review this

@Mindavi
Copy link
Copy Markdown
Contributor

Mindavi commented Jan 12, 2023

I can confirm this fixes the build closure. Build isn't fully done yet but I trust it'll pass on my side too.

@figsoda
Copy link
Copy Markdown
Member Author

figsoda commented Jan 12, 2023

I will merge this since there are no rebuilds

@figsoda figsoda merged commit 0defa75 into NixOS:staging-next Jan 12, 2023
@figsoda figsoda deleted the cross branch January 12, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mindavi Mindavi Mindavi approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@LnL7 LnL7 Awaiting requested review from LnL7

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@figsoda @Mindavi