Skip to content

nss_esr: 3.79.2 -> 3.79.3#210137

Merged
mweinelt merged 2 commits intoNixOS:stagingfrom
helsinki-systems:upd/nss
Jan 11, 2023
Merged

nss_esr: 3.79.2 -> 3.79.3#210137
mweinelt merged 2 commits intoNixOS:stagingfrom
helsinki-systems:upd/nss

Conversation

@ajs124
Copy link
Copy Markdown
Member

@ajs124 ajs124 commented Jan 11, 2023

Description of changes

Contains #208704

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Adam Joseph and others added 2 commits January 11, 2023 01:50
@ajs124
nss: convert NIX_CFLAGS_COMPILE to a list
eeb450e 
Nss has a lot of dependers, so subtle whitespace changes can cause
mass rebuilds, like I did here:

  NixOS#208698 (comment)

Let's use a list instead of concatenating individual strings in
order to be more robust.  This will cause a lot of rebuilds, but
will prevent rebuilds in the future.  Sending it this cleanup to
staging because of that.
@ajs124
nss_esr: 3.79.2 -> 3.79.3
3a41f83 
https://github.com/nss-dev/nss/blob/2d83f13617d0d1348ecc415e192a379c5170ecbc/doc/rst/releases/nss_3_79_3.rst
@ajs124 ajs124 mentioned this pull request Jan 11, 2023
Closed
13 tasks
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jan 11, 2023 •
edited
Loading

@ofborg eval

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 11, 2023
@mweinelt mweinelt merged commit 9653817 into NixOS:staging Jan 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 11, 2023

Backport failed for staging-22.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin staging-22.11
git worktree add -d .worktree/backport-210137-to-staging-22.11 origin/staging-22.11
cd .worktree/backport-210137-to-staging-22.11
git checkout -b backport-210137-to-staging-22.11
ancref=$(git merge-base d81bc4beae4fc72ef320285f2013262f76ac80dc 3a41f834f0c389d0c93caadb4336ed45a32f1ce9)
git cherry-pick -x $ancref..3a41f834f0c389d0c93caadb4336ed45a32f1ce9

@mweinelt mweinelt mentioned this pull request Jan 11, 2023
Merged
13 tasks
@ajs124 ajs124 deleted the upd/nss branch January 11, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukegb lukegb Awaiting requested review from lukegb

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajs124 @mweinelt