Skip to content

qemacs: fix cross-compilation#209417

Closed
ghost wants to merge 3 commits intomasterfrom
unknown repository
Closed

qemacs: fix cross-compilation#209417
ghost wants to merge 3 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 7, 2023

Description of changes

This fixes cross-compilation for qemacs. It also adds enableX11 parameter.

Things done
  • Built on platform(s)
    • x86_64-linux
    • powerpc64le-linux
    • aarch64-linux
    • mips64el-linux (cross from powerpc64le-linux)
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

qemacs: fix cross-compilation
3d9b72a 
Also adds enableX11 parameter.
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 7, 2023
@ofborg ofborg bot requested a review from iblech January 7, 2023 05:04
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 7, 2023
@Mindavi
Copy link
Copy Markdown
Contributor

Mindavi commented Jan 9, 2023

Build on darwin seems broken, is it related?

iblech
iblech approved these changes Jan 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@iblech iblech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for your work! I didn't test cross compilation, all the changes look very solid.

I cannot comment on the darwin situation.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 13, 2023

Build on darwin seems broken, is it related?

I'm afraid I do not have access to any darwin machines.

@Artturin
Copy link
Copy Markdown
Member

Artturin commented Jan 19, 2023

Build on darwin seems broken, is it related?

I'm afraid I do not have access to any darwin machines.

you can request access to https://github.com/winterqt/darwin-build-box if you want

Artturin
Artturin reviewed Jan 19, 2023
View reviewed changes
pkgs/applications/editors/qemacs/default.nix Outdated
Copy link
Copy Markdown
Member

@Artturin Artturin Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream assumes gcc

@Artturin
Copy link
Copy Markdown
Member

Artturin commented Jan 19, 2023

Build on darwin seems broken, is it related?

it's a pre-existing issue, fixed the gcc error but there's still

qe.c:32:31: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
int (*__initcall_first)(void) __init_call = NULL;
                              ^
./qe.h:581:57: note: expanded from macro '__init_call'
#define __init_call     __attribute__ ((unused,__section__ (".initcall.init")))
                                                            ^
qe.c:33:32: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
void (*__exitcall_first)(void) __exit_call = NULL;
                               ^
./qe.h:582:57: note: expanded from macro '__exit_call'
#define __exit_call     __attribute__ ((unused,__section__ (".exitcall.exit")))

Artturin
Artturin reviewed Jan 19, 2023
View reviewed changes
@ofborg ofborg bot requested a review from iblech January 19, 2023 16:10
@Mindavi
Copy link
Copy Markdown
Contributor

Mindavi commented Feb 22, 2023

Closed by #209418

@Mindavi Mindavi closed this Feb 22, 2023
@ghost ghost deleted the pr/qemacs/cross branch February 23, 2023 03:53
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iblech iblech Awaiting requested review from iblech

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mindavi @Artturin @iblech