Skip to content

gtk3: remove obsolete gobject-introspection from buildInputs #208945

Merged
sternenseemann merged 7 commits intoNixOS:stagingfrom
sternenseemann:gtk3-no-target-gobject-introspection
Jan 7, 2023
Merged

gtk3: remove obsolete gobject-introspection from buildInputs #208945
sternenseemann merged 7 commits intoNixOS:stagingfrom
sternenseemann:gtk3-no-target-gobject-introspection

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented Jan 3, 2023

Description of changes

Tested

  • pkgs.gtk3
  • pkgsCross.ghcjs.buildPackages.gtk3
  • pkgsCross.aarch64-multiplatform.gtk3
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 3, 2023
Copy link
Copy Markdown
Member

@Artturin Artturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgsCross.aarch64-multiplatform.gtk3 and gtk3 build

@sternenseemann sternenseemann marked this pull request as ready for review January 3, 2023 23:23
@sternenseemann sternenseemann merged commit 80db805 into NixOS:staging Jan 7, 2023
@sternenseemann sternenseemann deleted the gtk3-no-target-gobject-introspection branch January 7, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants