Skip to content

lib/systems/inspect.nix: add isILP32 predicate#208697

Merged
mweinelt merged 1 commit intomasterfrom
unknown repository
Jan 3, 2023
Merged

lib/systems/inspect.nix: add isILP32 predicate#208697
mweinelt merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 2, 2023

Description of changes

I've run into a few packages that need an extra flag on platforms where int has more bits than void* does. I know of three such platforms:

This PR introduces a predicate so the package flags can be added in a generic way.

Things done

I've run into a few packages that need an extra flag on platforms
where `int` has more bits than `void*` does.  I know of three such
platforms:

* [aarch64ilp32], used on both Linux and also on the [Apple Watch]
* [x32], the x86 ILP32 ABI
* [mips64n32], used on [Longsoon] and Cavium Octeon routers.

This PR introduces a predicate so the package flags can be added in
a generic way.

[Apple Watch]: https://gist.github.com/woachk/943828f37c14563a607a26116435bf27#watch
[mips64n32]: https://en.wikipedia.org/wiki/MIPS_architecture#Calling_conventions
[Longsoon]: https://en.wikipedia.org/wiki/Loongson
[x32]: https://en.wikipedia.org/wiki/X32_ABI
@ghost ghost requested review from Ericson2314, alyssais, matthewbauer and nbp as code owners January 2, 2023 01:22
@ghost ghost mentioned this pull request Jan 2, 2023
3 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 2, 2023
@mweinelt mweinelt merged commit 14f337a into NixOS:master Jan 3, 2023
@ghost ghost deleted the pr/systems/ilp32 branch January 3, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant