Skip to content

libftdi: do not force a build of python if !pythonSupport#208689

Merged
Artturin merged 1 commit intomasterfrom
unknown repository
Jan 3, 2023
Merged

libftdi: do not force a build of python if !pythonSupport#208689
Artturin merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 2, 2023

Description of changes

libftdi has a pythonSupport parameter, but still produces a (build-time) dependency on python even when it is set to false. This commit corrects that.

This allows building tiny systems (think embedded widgets) that need libftdi, without having to cross-build all of python for the target system.

Things done
  • Built on platform(s)
    • x86_64-linux
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

libftdi has a `pythonSupport` parameter, but still produces a
(build-time) dependency on python even when it is set to `false`.
This commit corrects that.

This allows building tiny systems (think embedded widgets) that need
libftdi, without having to cross-build all of python for the target
system.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 2, 2023
@Artturin Artturin merged commit 7d11350 into NixOS:master Jan 3, 2023
@ghost ghost deleted the pr/libftdi-pythonSupport branch January 3, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant