Skip to content

haskellPackages.git-brunch: unbreak#208131

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
andys8:haskell-unbreak-git-brunch
Dec 29, 2022
Merged

haskellPackages.git-brunch: unbreak#208131
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
andys8:haskell-unbreak-git-brunch

Conversation

@andys8
Copy link
Copy Markdown
Member

@andys8 andys8 commented Dec 28, 2022

Description of changes

The package was indeed broken for GHC 9.2. I fixed it, and it now succesfully compiles. A new version 1.6.0 is released. Also on hackage.

I had a look at other pull requests and comments how to unbreak. They normally only remove the package from the broken list and run the regenerate list.

How is the process in this case though? I need to update the version to v1.6.0. It will change the hash and dependencies. Is this something I can do or will it be done with the next update of haskell-updates?

Here I would need some advice. Thanks in advance.

Update

I tried the instructions for Initial haskell-updates PR

And indeed the result would look better. So, should the PR stay as is and the next haskell-updates PR will result in a new version?

  "git-brunch" = callPackage
    ({ mkDerivation, base, brick, extra, hspec, microlens
     , microlens-mtl, mtl, optparse-applicative, process, text, vector
     , vty
     }:
     mkDerivation {
       pname = "git-brunch";
       version = "1.6.0.0";
       sha256 = "1crpcv68lpfl0cs6cxmi7mcd1vawmif6qz1n0j2in49ypr75qkdk";
       isLibrary = false;
       isExecutable = true;
       executableHaskellDepends = [
         base brick extra hspec microlens microlens-mtl mtl
         optparse-applicative process text vector vty
       ];
       testHaskellDepends = [
         base brick extra hspec microlens microlens-mtl mtl
         optparse-applicative process text vector vty
       ];
       description = "git checkout command-line tool";
       license = lib.licenses.bsd3;
       mainProgram = "git-brunch";
     }) {};
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Dec 28, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 28, 2022
@cdepillabout cdepillabout merged commit cdfe559 into NixOS:haskell-updates Dec 29, 2022
@cdepillabout
Copy link
Copy Markdown
Member

This is exactly right. Thanks!

Also, it looks like git-brunch is already 1.6.0.0 on haskell-updates so this should be good to go!
#208126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants