haskellPackages.git-brunch: unbreak#208131
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Dec 29, 2022
andys8:haskell-unbreak-git-brunch
Merged
haskellPackages.git-brunch: unbreak#208131cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom andys8:haskell-unbreak-git-brunch
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
andys8:haskell-unbreak-git-brunch
Conversation
Member
|
This is exactly right. Thanks! Also, it looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The package was indeed broken for GHC 9.2. I fixed it, and it now succesfully compiles. A new version
1.6.0is released. Also on hackage.I had a look at other pull requests and comments how to unbreak. They normally only remove the package from the broken list and run the regenerate list.
How is the process in this case though? I need to update the version to v1.6.0. It will change the hash and dependencies. Is this something I can do or will it be done with the next update of
haskell-updates?Here I would need some advice. Thanks in advance.
Update
I tried the instructions for Initial haskell-updates PR
And indeed the result would look better. So, should the PR stay as is and the next
haskell-updatesPR will result in a new version?Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes