Skip to content

gtk2: drop unused xlibsWrapper import#207999

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:gtk2-without-xlibsWrapper
Dec 28, 2022
Merged

gtk2: drop unused xlibsWrapper import#207999
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:gtk2-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Dec 27, 2022

On linux it's not used at all. On darwin removal of the dependency does not change generated binaries. Should be a no-op as well.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

On linux it's not used at all. On darwin removal of the dependency does
not change generated binaries. Should be a no-op as well.
@trofi trofi mentioned this pull request Dec 27, 2022
83 tasks
@ofborg ofborg bot requested review from 7c6f434c and lovek323 December 27, 2022 19:20
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 27, 2022
@SuperSandro2000 SuperSandro2000 merged commit 3c92463 into NixOS:master Dec 28, 2022
@trofi trofi deleted the gtk2-without-xlibsWrapper branch December 28, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants