Skip to content

poetry2nix: drop unused pkgs.xlibsWrapper import#207729

Merged
Mindavi merged 1 commit intoNixOS:stagingfrom
trofi:poentry2nix-removal-of-xlibsWrappers
Dec 27, 2022
Merged

poetry2nix: drop unused pkgs.xlibsWrapper import#207729
Mindavi merged 1 commit intoNixOS:stagingfrom
trofi:poentry2nix-removal-of-xlibsWrappers

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Dec 25, 2022 •
edited
Loading

It's a cherry-pick of upstream
nix-community/poetry2nix#897

Merging this earlier will allow removing xlibsWrapper entirely.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
poetry2nix: drop unused pkgs.xlibsWrapper import
e709c57 
It's a cherry-pick of upstream
nix-community/poetry2nix#897

Merging this earlier will allow removing `xlibsWrapper` entirely.
@trofi trofi requested a review from adisbladis as a code owner December 25, 2022 20:25
@trofi trofi mentioned this pull request Dec 25, 2022
Closed
83 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 25, 2022
@Mindavi Mindavi merged commit 7843a26 into NixOS:staging Dec 27, 2022
@trofi trofi deleted the poentry2nix-removal-of-xlibsWrappers branch December 27, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mindavi Mindavi Mindavi approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @Mindavi