Skip to content

python3Packages.blis: 0.9.1 -> 0.7.9#207070

Merged
wegank merged 1 commit intoNixOS:masterfrom
danieldk:versions/blis-0.7.9
Feb 3, 2023
Merged

python3Packages.blis: 0.9.1 -> 0.7.9#207070
wegank merged 1 commit intoNixOS:masterfrom
danieldk:versions/blis-0.7.9

Conversation

@danieldk
Copy link
Copy Markdown
Contributor

@danieldk danieldk commented Dec 21, 2022

Description of changes

The blis 0.9.x packages cause segmentation faults:

explosion/thinc#771 (comment)

For this reason, Thinc/spaCy (the only users of this package in nixpkgs) have reverted to 0.7.x until this issue is resolved.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@danieldk
python3Packages.blis: 0.9.1 -> 0.7.9
4346bba 
The blis 0.9.x packages cause segmentation faults:

explosion/thinc#771 (comment)

For this reason, Thinc/spaCy (the only users of this package in
nixpkgs) have reverted to 0.7.x until this issue is resolved.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 21, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 21, 2022
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Jan 21, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1736

@mattmelling
Copy link
Copy Markdown
Contributor

mattmelling commented Jan 26, 2023

blis builds fine and lgtm, the other spacy packages still appear broken.

Result of nixpkgs-review pr 207070 run on x86_64-linux 1

6 packages failed to build:
  • python310Packages.spacy
  • python310Packages.spacy-transformers
  • python310Packages.textacy
  • python39Packages.spacy
  • python39Packages.spacy-transformers
  • python39Packages.textacy
4 packages built:
  • python310Packages.blis
  • python310Packages.thinc
  • python39Packages.blis
  • python39Packages.thinc

This was referenced Jan 26, 2023
Merged
Merged
@wegank
Copy link
Copy Markdown
Member

wegank commented Jan 30, 2023

@ofborg build python310Packages.spacy

This was referenced Jan 30, 2023
Merged
Merged
@wegank wegank marked this pull request as draft January 30, 2023 20:11
@danieldk
Copy link
Copy Markdown
Contributor Author

danieldk commented Feb 2, 2023

Why is this put in draft?

@wegank
Copy link
Copy Markdown
Member

wegank commented Feb 2, 2023

For this reason, Thinc/spaCy (the only users of this package in nixpkgs) have reverted to 0.7.x until this issue is resolved.

This does not fix python310Packages.spacy according to ofborg and a nixpkgs-review in the comments. I think additional patching or downgrades need to be done to prove the point.

@mattmelling
Copy link
Copy Markdown
Contributor

mattmelling commented Feb 3, 2023

@wegank Hydra shows spacy is currently breaking (via thinc) because of the blis version, this pull gets thinc building but then spacy needs the wasabi update linked above.

@wegank wegank marked this pull request as ready for review February 3, 2023 00:53
@wegank
Copy link
Copy Markdown
Member

wegank commented Feb 3, 2023

@ofborg build python3Packages.thinc

@wegank wegank merged commit e481552 into NixOS:master Feb 3, 2023
@danieldk danieldk deleted the versions/blis-0.7.9 branch February 4, 2023 12:59
@wegank
Copy link
Copy Markdown
Member

wegank commented Mar 17, 2023

Is blis again at 0.9.1 on master?

@danieldk
Copy link
Copy Markdown
Contributor Author

danieldk commented Mar 22, 2023

Seems so 😢 #218614

This was referenced Mar 22, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danieldk @nixos-discourse @mattmelling @wegank