awscli2: make version widening more robust#206460
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Dec 17, 2022
Merged
Conversation
anthonyroussel
approved these changes
Dec 16, 2022
Member
anthonyroussel
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 206460 run on x86_64-linux 1
2 packages built:
- awscli2
- liquidsoap
dotlambda
reviewed
Dec 17, 2022
Member
dotlambda
left a comment
There was a problem hiding this comment.
Why not use pythonRelaxDepsHook?
Member
|
I merged a bit early. Better have it working than not. Certainly feel free to improve further. |
Member
Author
that only works with requirements.txt |
Member
No, also with |
Member
Author
|
thats only mentioned in the last sentence of https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#using-pythonrelaxdepshook-using-pythonrelaxdepshook and up to that point examples are only given for requirements.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes