Merged
Conversation
joachifm
reviewed
Nov 24, 2016
| # Move the extracted tarball into the output folder | ||
| mv "$packageDir" "$DIR/${packageName}" | ||
| elif [ -d "${src}" ] | ||
| then |
Contributor
There was a problem hiding this comment.
The comment says that strippedName would be set on older nixpkgs, implying that it is unset in newer versions (and so must be set). Is that not the case?
Contributor
Author
There was a problem hiding this comment.
I only added one line in pkgs/top-level/node-packages.json, the other changes are auto generated by a script, invoked to the letter of the instructions AFAIK.
Contributor
|
cc @svanderburg might be able to comment on this. |
Member
|
Tested and everything seems to work. |
Contributor
|
In the mean time, Yarn is at 0.17.10 :) |
Contributor
Author
|
Then I'll update it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Yarn is a new javascript packagemanager by Facebook, inspired by Bundler and Cargo.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)