Skip to content

ocaml-ng.ocamlPackages_4_00_1.ocaml: use xorg.* packages directly ins…#205480

Merged
trofi merged 1 commit intoNixOS:masterfrom
trofi:ocaml-4_00_1-without-xlibsWrapper
Dec 11, 2022
Merged

ocaml-ng.ocamlPackages_4_00_1.ocaml: use xorg.* packages directly ins…#205480
trofi merged 1 commit intoNixOS:masterfrom
trofi:ocaml-4_00_1-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Dec 10, 2022 •
edited
Loading

…tead of xlibsWrapper indirection

Validated as no material change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
ocaml-ng.ocamlPackages_4_00_1.ocaml: use xorg.* packages directly ins…
79eaf1d 
…tead of xlibsWrapper indirection

Validated as no material change in `out` output with `diffoscope`.
@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Dec 10, 2022
@trofi trofi mentioned this pull request Dec 10, 2022
Closed
83 tasks
@trofi
Copy link
Copy Markdown
Contributor Author

trofi commented Dec 10, 2022

Result of nixpkgs-review pr 205480 run on x86_64-linux 1

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 10, 2022
@trofi trofi merged commit bee0009 into NixOS:master Dec 11, 2022
@trofi trofi deleted the ocaml-4_00_1-without-xlibsWrapper branch December 11, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbgl vbgl vbgl approved these changes

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @vbgl