Skip to content

hugin: cherrypick fix for segfault on empty XDG_DATA_DIR#204740

Merged
Artturin merged 1 commit intomasterfrom
unknown repository
Dec 10, 2022
Merged

hugin: cherrypick fix for segfault on empty XDG_DATA_DIR#204740
Artturin merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 6, 2022

Description of changes

Hugin segfaults if the environment variable XDG_DATA_DIR is unset (rather than being the empty string). Upstream has committed a fix in edfddc6070ca6d4223d359fb4b38273a5aed2f2d but has not released it (hugin releases are very infrequent).

Let's cherry-pick the fix since it might be a while before they manage another release.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Hugin segfaults if the environment variable XDG_DATA_DIR is unset
(rather than being the empty string).  Upstream has committed a fix
in edfddc6070ca6d4223d359fb4b38273a5aed2f2d but has not released it
(hugin releases are *very* infrequent).

Let's cherry-pick the fix since it might be a while before they
manage another release.
@ofborg ofborg bot requested a review from hrdinka December 6, 2022 06:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 6, 2022
@Artturin Artturin merged commit 790020f into NixOS:master Dec 10, 2022
@ghost ghost deleted the hugin1 branch January 1, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant