Skip to content

qt6Packages.qtbase: drop unused xlibsWrapper#204687

Merged
trofi merged 1 commit intoNixOS:masterfrom
trofi:qt6Packages.qtbase-without-xlibsWrapper
Dec 6, 2022
Merged

qt6Packages.qtbase: drop unused xlibsWrapper#204687
trofi merged 1 commit intoNixOS:masterfrom
trofi:qt6Packages.qtbase-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Dec 5, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi trofi mentioned this pull request Dec 5, 2022
Closed
83 tasks
@ofborg ofborg bot requested review from LunNova and NickCao December 5, 2022 21:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Dec 5, 2022
@trofi trofi changed the base branch from staging to master December 5, 2022 22:33
@trofi
Copy link
Copy Markdown
Contributor Author

trofi commented Dec 5, 2022

under 500 might be good enough for nixpkgs-review.

@LunNova
Copy link
Copy Markdown
Member

LunNova commented Dec 5, 2022

Can't review run, review ran uncovered a hardware issue with my build machine, bit got flipped causing a compile error.

../../../../../src/3rdparty/chromium/base/containers/circular_deque.h:290:26: error: 'ctatic_cast' was not declared in this scope
  290 |            new_offset <= static_cast<difference_type>(parent_deque_->size()));
      |                          ^~~~~~~~~~~

Code change looks good.

@trofi
Copy link
Copy Markdown
Contributor Author

trofi commented Dec 6, 2022

Result of nixpkgs-review pr 204687 run on x86_64-linux 1

1 package marked as broken and skipped:
  • obs-studio-plugins.obs-hyperion
84 packages built:
  • beamerpresenter (beamerpresenter-mupdf)
  • beamerpresenter-poppler
  • calcmysky
  • calibre
  • cudaPackages.nsight_compute
  • cutemaze
  • duckstation
  • fcitx5-chinese-addons
  • fcitx5-configtool
  • fcitx5-unikey
  • fcitx5-with-addons
  • gpxsee-qt6
  • jami-client
  • ladybird
  • libsForQt5.fcitx5-qt (plasma5Packages.fcitx5-qt)
  • maestral-gui
  • mozillavpn
  • obs-studio
  • obs-studio-plugins.input-overlay
  • obs-studio-plugins.looking-glass-obs
  • obs-studio-plugins.obs-backgroundremoval
  • obs-studio-plugins.obs-gstreamer
  • obs-studio-plugins.obs-move-transition
  • obs-studio-plugins.obs-multi-rtmp
  • obs-studio-plugins.obs-nvfbc
  • obs-studio-plugins.obs-pipewire-audio-capture
  • obs-studio-plugins.obs-source-record
  • obs-studio-plugins.obs-vkcapture
  • obs-studio-plugins.wlrobs
  • pokefinder
  • prismlauncher
  • python310Packages.pyqt6
  • python310Packages.pyqt6-webengine
  • python39Packages.pyqt6
  • python39Packages.pyqt6-webengine
  • qMasterPassword
  • qmmp
  • qt6.full (qt6Packages.full)
  • qt6.qmake (qt6Packages.qmake)
  • qt6.qt3d (qt6Packages.qt3d)
  • qt6.qt5compat (qt6Packages.qt5compat)
  • qt6.qtbase (qt6Packages.qtbase)
  • qt6.qtcharts (qt6Packages.qtcharts)
  • qt6.qtconnectivity (qt6Packages.qtconnectivity)
  • qt6.qtdatavis3d (qt6Packages.qtdatavis3d)
  • qt6.qtdeclarative (qt6Packages.qtdeclarative)
  • qt6.qtdoc (qt6Packages.qtdoc)
  • qt6.qthttpserver (qt6Packages.qthttpserver)
  • qt6.qtimageformats (qt6Packages.qtimageformats)
  • qt6.qtlanguageserver (qt6Packages.qtlanguageserver)
  • qt6.qtlottie (qt6Packages.qtlottie)
  • qt6.qtmultimedia (qt6Packages.qtmultimedia)
  • qt6.qtnetworkauth (qt6Packages.qtnetworkauth)
  • qt6.qtpositioning (qt6Packages.qtpositioning)
  • qt6.qtquick3d (qt6Packages.qtquick3d)
  • qt6.qtquick3dphysics (qt6Packages.qtquick3dphysics)
  • qt6.qtquicktimeline (qt6Packages.qtquicktimeline)
  • qt6.qtremoteobjects (qt6Packages.qtremoteobjects)
  • qt6.qtscxml (qt6Packages.qtscxml)
  • qt6.qtsensors (qt6Packages.qtsensors)
  • qt6.qtserialbus (qt6Packages.qtserialbus)
  • qt6.qtserialport (qt6Packages.qtserialport)
  • qt6.qtshadertools (qt6Packages.qtshadertools)
  • qt6.qtspeech (qt6Packages.qtspeech)
  • qt6.qtsvg (qt6Packages.qtsvg)
  • qt6.qttools (qt6Packages.qttools)
  • qt6.qttranslations (qt6Packages.qttranslations)
  • qt6.qtvirtualkeyboard (qt6Packages.qtvirtualkeyboard)
  • qt6.qtwayland (qt6Packages.qtwayland)
  • qt6.qtwebchannel (qt6Packages.qtwebchannel)
  • qt6.qtwebengine (qt6Packages.qtwebengine)
  • qt6.qtwebsockets (qt6Packages.qtwebsockets)
  • qt6.qtwebview (qt6Packages.qtwebview)
  • qt6Packages.kcoreaddons
  • qt6Packages.poppler
  • qt6Packages.qtpbfimageplugin
  • qt6Packages.quazip
  • qt6Packages.qxlsx
  • qutebrowser-qt6
  • retext
  • stellarium
  • tdesktop
  • zeal-qt6
  • zint

@trofi trofi merged commit 51f76dc into NixOS:master Dec 6, 2022
@trofi trofi deleted the qt6Packages.qtbase-without-xlibsWrapper branch December 6, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@NickCao NickCao NickCao approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trofi @LunNova @SuperSandro2000 @NickCao