Skip to content

gnustep.back: use xorg.* packages directly instead of xlibsWrapper in…#204347

Merged
trofi merged 1 commit intoNixOS:masterfrom
trofi:gnustep.back-without-xlibsWrapper
Dec 4, 2022
Merged

gnustep.back: use xorg.* packages directly instead of xlibsWrapper in…#204347
trofi merged 1 commit intoNixOS:masterfrom
trofi:gnustep.back-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Dec 3, 2022 •
edited
Loading

…direction

Validated as no change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
gnustep.back: use xorg.* packages directly instead of xlibsWrapper in…
50ae212 
…direction

Validated as no change in `out` output with `diffoscope`.
@trofi trofi mentioned this pull request Dec 3, 2022
Closed
83 tasks
@trofi
Copy link
Copy Markdown
Contributor Author

trofi commented Dec 3, 2022

Result of nixpkgs-review pr 204347 run on x86_64-linux 1

1 package failed to build:
  • gnustep.projectcenter
5 packages built:
  • gnustep.back
  • gnustep.gorm
  • gnustep.gworkspace
  • gnustep.system_preferences
  • pikopixel

@trofi
Copy link
Copy Markdown
Contributor Author

trofi commented Dec 3, 2022

gnustep.projectcenter

Already broken in master before this change.

@ofborg ofborg bot requested review from ashalkhakov and matthewbauer December 3, 2022 20:38
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 3, 2022
@trofi trofi merged commit 55f9ef8 into NixOS:master Dec 4, 2022
@trofi trofi deleted the gnustep.back-without-xlibsWrapper branch December 4, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashalkhakov ashalkhakov Awaiting requested review from ashalkhakov

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@trofi