Skip to content

obfs4: 0.0.12 -> 0.0.14#203929

Merged
fabaff merged 3 commits intoNixOS:masterfrom
marsam:update-obfs4
Dec 4, 2022
Merged

obfs4: 0.0.12 -> 0.0.14#203929
fabaff merged 3 commits intoNixOS:masterfrom
marsam:update-obfs4

Conversation

@marsam
Copy link
Copy Markdown
Contributor

@marsam marsam commented Dec 1, 2022

Description of changes

https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/obfs4/-/raw/obfs4proxy-0.0.14/ChangeLog

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice December 1, 2022 14:00
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 1, 2022
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Dec 4, 2022

Result of nixpkgs-review pr 203929 run on x86_64-linux 1

3 packages built:
  • obfs4
  • onionshare
  • onionshare-gui

fabaff
fabaff approved these changes Dec 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 7422831 into NixOS:master Dec 4, 2022
@taku0 taku0 mentioned this pull request Dec 23, 2022
Closed
13 tasks
@marsam marsam deleted the update-obfs4 branch May 31, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marsam @fabaff