Skip to content

Bitcoin forks cleanup#202664

Merged
K900 merged 5 commits intoNixOS:masterfrom
rnhmjoj:pr-bitcoin-cleanup
Nov 24, 2022
Merged

Bitcoin forks cleanup#202664
K900 merged 5 commits intoNixOS:masterfrom
rnhmjoj:pr-bitcoin-cleanup

Conversation

@rnhmjoj
Copy link
Copy Markdown
Contributor

@rnhmjoj rnhmjoj commented Nov 24, 2022 •
edited
Loading

Description of changes

Remove dead bitcoin forks for #201765

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change
  • Tested basic functionality of all binary files
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

cc @jefdaj @mmahut @DmitryTsygankov

@rnhmjoj
bitcoin-classic: remove
9fff86f 
Motivations:

  1. The project having been closed for 5 years,
  2. 1 BXC is now worth less than 1 ¢,
  3. It will stop building once Qt 5.14 is removed.
@rnhmjoj rnhmjoj mentioned this pull request Nov 24, 2022
Closed
31 tasks
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 24, 2022
@K900
Copy link
Copy Markdown
Contributor

K900 commented Nov 24, 2022

vertcoin and digibyte are more dead cryptos.

@rnhmjoj
Copy link
Copy Markdown
Contributor Author

rnhmjoj commented Nov 24, 2022

vertcoin looks pretty dead, but has at least been updated this year.
digibyte is dead indeed.

@rnhmjoj
bitcoin-gold: remove
ce270b3 
Motivations:

1. Bitcoin Gold has been unmmaintained since 2020
2. The GUI wallet doesn't support Qt > 5.14, which is deprecated
@rnhmjoj
bitcoin-unlimited: build with latest Qt
02f8117
@rnhmjoj
digibyte: remove
333f2ef 
Motivations:

  1. digibyte has been unmmaintained since 2019
  2. The GUI wallet doesn't support Qt > 5.14, which is deprecated
@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Nov 24, 2022
@K900 K900 merged commit 812a5d6 into NixOS:master Nov 24, 2022
@github-actions github-actions bot mentioned this pull request Nov 24, 2022
Closed
1 task
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2022

Successfully created backport PR #202724 for release-22.11.

@NickCao NickCao mentioned this pull request Jan 25, 2023
Closed
13 tasks
@rnhmjoj rnhmjoj deleted the pr-bitcoin-cleanup branch July 10, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

+1 more reviewer

@dasj19 dasj19 dasj19 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rnhmjoj @K900 @thiagokokada @dasj19