Skip to content

carnix,cratesIO: remove#202394

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
figsoda:remove-carnix
Nov 22, 2022
Merged

carnix,cratesIO: remove#202394
Mic92 merged 1 commit intoNixOS:masterfrom
figsoda:remove-carnix

Conversation

@figsoda
Copy link
Copy Markdown
Member

@figsoda figsoda commented Nov 22, 2022

Description of changes

closes #57235
closes #195279

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested review from LnL7, Mic92 and zowoq as code owners November 22, 2022 19:15
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Nov 22, 2022
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 22, 2022
@Mic92 Mic92 merged commit 40b7b8c into NixOS:master Nov 22, 2022
@figsoda figsoda deleted the remove-carnix branch November 22, 2022 19:41
@ghost
Copy link
Copy Markdown

ghost commented Mar 16, 2023

This PR deleted the documentation for buildRustCrate, which is used by crate2nix. It is not carnix-specific.

@ghost ghost mentioned this pull request Mar 16, 2023
Merged
1 task
@figsoda
Copy link
Copy Markdown
Member Author

figsoda commented Mar 16, 2023

The documentation is basically for carnix, but I agree we can bring the section back but for crate2nix instead

@niklaskorz niklaskorz mentioned this pull request Jan 14, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@LnL7 LnL7 Awaiting requested review from LnL7

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate carnix and cratesIO remove carnix from the nixpkgs manual

2 participants

@figsoda @Mic92