Skip to content

Installation-cd: Remove libsForQt5.full#201991

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
vlinkz:calamaresqtwebkit
Nov 20, 2022
Merged

Installation-cd: Remove libsForQt5.full#201991
mweinelt merged 1 commit intoNixOS:masterfrom
vlinkz:calamaresqtwebkit

Conversation

@vlinkz
Copy link
Copy Markdown
Member

@vlinkz vlinkz commented Nov 20, 2022

Description of changes

Stop using qtwebkit.
Reference: #201028

Things done

Removed libsForQt5.full from installation cd dependencies. Seems to not be required for calamares anymore.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 20, 2022
@vlinkz vlinkz mentioned this pull request Nov 20, 2022
Merged
13 tasks
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Nov 20, 2022 •
edited
Loading

Wow, that's surprising.

I'm now getting this, which is baffling. Oh, it's trying to build for i686-linux 🙈

❯ nom-build release-combined.nix -A nixos.iso_gnome
error: Package ‘firefox-107.0’ in /home/hexa/git/nixos/master/pkgs/applications/networking/browsers/firefox/wrapper.nix:404 is marked as broken, refusing to evaluate.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 20, 2022
@mweinelt mweinelt merged commit 0db9431 into NixOS:master Nov 20, 2022
@vlinkz vlinkz deleted the calamaresqtwebkit branch November 27, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlinkz @mweinelt