Skip to content

ocamlPackages.ocaml-lsp: 1.14.1 -> 1.14.2#200164

Merged
vbgl merged 3 commits intoNixOS:masterfrom
ulrikstrid:ulrikstrid--ocaml-lsp_1_14_2
Nov 11, 2022
Merged

ocamlPackages.ocaml-lsp: 1.14.1 -> 1.14.2#200164
vbgl merged 3 commits intoNixOS:masterfrom
ulrikstrid:ulrikstrid--ocaml-lsp_1_14_2

Conversation

@ulrikstrid
Copy link
Copy Markdown
Member

@ulrikstrid ulrikstrid commented Nov 8, 2022 •
edited
Loading

Description of changes

ocaml/opam-repository#22456

needs:
#196899 (or it could supersede)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Nov 8, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 8, 2022
@ulrikstrid ulrikstrid force-pushed the ulrikstrid--ocaml-lsp_1_14_2 branch from ec20015 to 2f69fb5 Compare November 8, 2022 08:37
@ulrikstrid ulrikstrid force-pushed the ulrikstrid--ocaml-lsp_1_14_2 branch from 2f69fb5 to c584948 Compare November 8, 2022 08:39
@ulrikstrid ulrikstrid requested review from marsam and vbgl November 8, 2022 08:39
@ulrikstrid ulrikstrid changed the title ocaml-lsp: 1.14.1 -> 1.14.2 ocamlPackages.ocaml-lsp: 1.14.1 -> 1.14.2 Nov 8, 2022
@ulrikstrid ulrikstrid marked this pull request as ready for review November 8, 2022 08:40
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 8, 2022
@vbgl
Copy link
Copy Markdown
Contributor

vbgl commented Nov 8, 2022

@GrahamcOfBorg build ocamlPackages.dune-action-plugin

@vbgl
Copy link
Copy Markdown
Contributor

vbgl commented Nov 8, 2022

This breaks dune-action-plugin.

@ulrikstrid ulrikstrid force-pushed the ulrikstrid--ocaml-lsp_1_14_2 branch from c584948 to 6922ded Compare November 9, 2022 16:04
@ulrikstrid
Copy link
Copy Markdown
Member Author

ulrikstrid commented Nov 9, 2022

@vbgl fixed dune-action-plugin and dune-rpc which needed to propagate dependencies

vbgl
vbgl reviewed Nov 9, 2022
View reviewed changes
@ulrikstrid ulrikstrid force-pushed the ulrikstrid--ocaml-lsp_1_14_2 branch from 05df0ec to 68dd3b7 Compare November 9, 2022 20:50
@ulrikstrid ulrikstrid requested a review from vbgl November 9, 2022 20:51
@ulrikstrid
Copy link
Copy Markdown
Member Author

ulrikstrid commented Nov 10, 2022

I think this is good to go @vbgl @marsam

@vbgl vbgl merged commit ef62f65 into NixOS:master Nov 11, 2022
@ulrikstrid ulrikstrid deleted the ulrikstrid--ocaml-lsp_1_14_2 branch November 11, 2022 14:59
@ulrikstrid ulrikstrid mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marsam marsam Awaiting requested review from marsam

@vbgl vbgl Awaiting requested review from vbgl

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ulrikstrid @vbgl