Skip to content

libiio: allow build on systems without avahi#199959

Merged
Artturin merged 1 commit intomasterfrom
unknown repository
Nov 8, 2022
Merged

libiio: allow build on systems without avahi#199959
Artturin merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 7, 2022

Description of changes

#181875 seems to have made this
package and its downstream dependencies no longer build on
avahi-less systems. Let's make it possible for them to build again.

CC @Artturin

Things done

@ofborg ofborg bot requested a review from thoughtpolice November 7, 2022 02:42
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 7, 2022
@wentasah
Copy link
Copy Markdown
Contributor

wentasah commented Nov 7, 2022

Code LGTM. However, the PR/commit title should not be about unbreaking, but about making avahi an optional dependency. To unbreak anything, one has to callPackage with avahiSupport = false.

#181875 seems to have made this
package and its downstream dependencies no longer build on
avahi-less systems.  Let's make it possible for them to build again.
@ghost ghost changed the title libiio: unbreak systems without avahi libiio: make it build on systems without avahi Nov 7, 2022
@ghost ghost changed the title libiio: make it build on systems without avahi libiio: allow build on systems without avahi Nov 7, 2022
@Artturin Artturin merged commit 2fe8fa4 into NixOS:master Nov 8, 2022
@ghost ghost deleted the pr/libiio/avahiSupport branch November 11, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants