Skip to content

nedit: use xorg.* packages directly instead of xlibsWrapper indirection#198611

Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom
trofi:nedit-without-xlibsWrapper
Oct 30, 2022
Merged

nedit: use xorg.* packages directly instead of xlibsWrapper indirection#198611
AndersonTorres merged 1 commit intoNixOS:masterfrom
trofi:nedit-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Oct 30, 2022 •
edited
Loading

Tested as no material change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi trofi mentioned this pull request Oct 30, 2022
Closed
83 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 30, 2022
AndersonTorres
AndersonTorres suggested changes Oct 30, 2022
View reviewed changes
@trofi @AndersonTorres
nedit: use xorg.* packages directly instead of xlibsWrapper indirection
da9574e 
Tested as no material change in `out` output with `diffoscope`.

Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@trofi trofi force-pushed the nedit-without-xlibsWrapper branch from c0ff3f5 to da9574e Compare October 30, 2022 14:48
@trofi trofi requested a review from AndersonTorres October 30, 2022 14:49
@AndersonTorres AndersonTorres merged commit 5527a41 into NixOS:master Oct 30, 2022
@trofi trofi deleted the nedit-without-xlibsWrapper branch October 30, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @AndersonTorres