boehmgc: disabled tests on powerpc64le-linux#198591
Closed
jiegec wants to merge 1 commit intoNixOS:masterfrom
Closed
boehmgc: disabled tests on powerpc64le-linux#198591jiegec wants to merge 1 commit intoNixOS:masterfrom
jiegec wants to merge 1 commit intoNixOS:masterfrom
Conversation
trofi
approved these changes
Nov 5, 2022
ghost
suggested changes
Nov 7, 2022
ghost
left a comment
There was a problem hiding this comment.
Please don't merge this.
The problem on Darwin is caused by the Rosetta emulator; it has nothing to do with the powerpc64le situation:
The test failure isn't a false positive.
Disabling the tests here is risky. Remember that Nix itself uses boehm-gc.
I'm filing another PR that disables the optimization which is causing the tests to fail. Github won't let me ```suggest it here because it touches parts of the file which are more than three lines away from your changes.
|
Please consider #199978 instead. |
13 tasks
Member
Author
|
Closed in favor of #199991 199978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
See bdwgc/bdwgc#376, the upstream bug has not been fixed.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes