Skip to content

vlc: use xorg.libSM packages directly instead of xlibsWrapper indirection#198496

Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom
LeSuisse:vlc-no-xlibsWrapper
Oct 29, 2022
Merged

vlc: use xorg.libSM packages directly instead of xlibsWrapper indirection#198496
AndersonTorres merged 1 commit intoNixOS:masterfrom
LeSuisse:vlc-no-xlibsWrapper

Conversation

@LeSuisse
Copy link
Copy Markdown
Member

@LeSuisse LeSuisse commented Oct 29, 2022

Description of changes

See #194054

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

5 packages marked as broken and skipped:
  • elisa
  • libsForQt512.elisa
  • libsForQt512.phonon-backend-vlc
  • libsForQt514.elisa
  • libsForQt514.phonon-backend-vlc
1 package failed to build:
  • obs-studio-plugins.obs-ndi
33 packages built:
  • arcanPackages.all-wrapped
  • arcanPackages.arcan
  • arcanPackages.arcan-wrapped
  • arcanPackages.cat9-wrapped
  • arcanPackages.durden-wrapped
  • arcanPackages.pipeworld-wrapped
  • arcanPackages.prio-wrapped
  • arcanPackages.xarcan
  • kaffeine
  • kphotoalbum
  • libsForQt5.elisa
  • libsForQt5.phonon-backend-vlc
  • libvlc
  • megaglest
  • minitube
  • obs-studio
  • obs-studio-plugins.looking-glass-obs
  • obs-studio-plugins.obs-backgroundremoval
  • obs-studio-plugins.obs-gstreamer
  • obs-studio-plugins.obs-move-transition
  • obs-studio-plugins.obs-multi-rtmp
  • obs-studio-plugins.obs-nvfbc
  • obs-studio-plugins.obs-pipewire-audio-capture
  • obs-studio-plugins.obs-vkcapture
  • obs-studio-plugins.obs-websocket
  • obs-studio-plugins.wlrobs
  • openlpFull
  • pympress
  • python310Packages.python-vlc
  • python39Packages.python-vlc
  • reaper
  • strawberry
  • vlc

@ofborg ofborg bot requested a review from AndersonTorres October 29, 2022 17:06
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 29, 2022
@AndersonTorres AndersonTorres merged commit 255b2ae into NixOS:master Oct 29, 2022
@LeSuisse LeSuisse deleted the vlc-no-xlibsWrapper branch October 29, 2022 19:18
@trofi trofi mentioned this pull request Oct 30, 2022
Closed
83 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LeSuisse @AndersonTorres