Skip to content

xidlehook: use xorg.* packages directly instead of xlibsWrappe…#198436

Merged
bjornfor merged 1 commit intoNixOS:masterfrom
trofi:xidlehook-without-xlibsWrapper
Oct 29, 2022
Merged

xidlehook: use xorg.* packages directly instead of xlibsWrappe…#198436
bjornfor merged 1 commit intoNixOS:masterfrom
trofi:xidlehook-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Oct 29, 2022 •
edited
Loading

…r indirection

Tested as no material change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi trofi mentioned this pull request Oct 29, 2022
Closed
83 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 29, 2022
bjornfor
bjornfor requested changes Oct 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove xxgdb: from commit message?

@trofi
xidlehook: use xorg.* packages directly instead of xlibsWrapper indir…
98d72f9 
…ection

Tested as no material change in `out` output with `diffoscope`.
@trofi trofi force-pushed the xidlehook-without-xlibsWrapper branch from 65c055a to 98d72f9 Compare October 29, 2022 12:46
@trofi trofi changed the title xidlehook: xxgdb: use xorg.* packages directly instead of xlibsWrappe… xidlehook: use xorg.* packages directly instead of xlibsWrappe… Oct 29, 2022
@trofi trofi requested a review from bjornfor October 29, 2022 12:47
@trofi
Copy link
Copy Markdown
Contributor Author

trofi commented Oct 29, 2022

Ah, good catch! Updated.

@bjornfor bjornfor merged commit 68eea64 into NixOS:master Oct 29, 2022
@trofi trofi deleted the xidlehook-without-xlibsWrapper branch October 29, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @bjornfor