Skip to content

pulseaudio: Don't depend on systemd when doing libonly#195979

Closed
peperunas wants to merge 3 commits intoNixOS:stagingfrom
peperunas:pulseaudio-i686
Closed

pulseaudio: Don't depend on systemd when doing libonly#195979
peperunas wants to merge 3 commits intoNixOS:stagingfrom
peperunas:pulseaudio-i686

Conversation

@peperunas
Copy link
Copy Markdown
Contributor

@peperunas peperunas commented Oct 14, 2022

Description of changes

This issue is part of a series of bugfixes to improve the i686 cross-compilation pipeline.

Tracking issue: #195967

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@peperunas peperunas mentioned this pull request Oct 14, 2022
Open
@ofborg ofborg bot requested a review from lovek323 October 14, 2022 14:01
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 14, 2022
@lovesegfault
Copy link
Copy Markdown
Member

lovesegfault commented Oct 14, 2022

This has to target staging due to the mass rebuilds

@peperunas peperunas changed the base branch from master to staging October 15, 2022 15:38
risicle
risicle reviewed Oct 15, 2022
View reviewed changes
alyssais
alyssais previously requested changes Oct 15, 2022
View reviewed changes
@peperunas peperunas requested review from alyssais and risicle and removed request for alyssais and lovek323 October 20, 2022 13:44
@ofborg ofborg bot requested a review from lovek323 October 20, 2022 14:23
@lovesegfault lovesegfault requested a review from alyssais November 4, 2022 14:52
@Artturin
Copy link
Copy Markdown
Member

Artturin commented Feb 19, 2023

libOnly already means that systemd isn't a dep

nixpkgs/pkgs/servers/pulseaudio/default.nix

Lines 76 to 80 in 042598f

++ lib.optionals (!libOnly) (
[ libasyncns webrtc-audio-processing ]
++ lib.optional jackaudioSupport libjack2
++ lib.optionals x11Support [ xorg.libICE xorg.libSM xorg.libX11 xorg.libXi xorg.libXtst ]
++ lib.optional useSystemd systemd

@Artturin Artturin closed this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle Awaiting requested review from risicle

@lovek323 lovek323 Awaiting requested review from lovek323

@alyssais alyssais Awaiting requested review from alyssais

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@peperunas @lovesegfault @Artturin @risicle @alyssais @Ericson2314