libnftnl: Enable parallel building. Disable -fortify when cross-compiling with Clang#195975
Closed
peperunas wants to merge 2 commits intoNixOS:stagingfrom
Closed
libnftnl: Enable parallel building. Disable -fortify when cross-compiling with Clang#195975peperunas wants to merge 2 commits intoNixOS:stagingfrom
peperunas wants to merge 2 commits intoNixOS:stagingfrom
Conversation
Member
|
This has to target staging due to the mass rebuilds. |
risicle
reviewed
Oct 15, 2022
Contributor
There was a problem hiding this comment.
You sure this isn't an exported symbol and we're not changing the ABI by doing this?
Contributor
There was a problem hiding this comment.
Also, have you checked this can't be solved by simply doing hardeningDisable = lib.optional stdenv.cc.isClang "fortify"?
I would check but I'm unable to reproduce your problem - don't know how you're building things but pkgsLLVM.libnftnl builds for me without problems.
Contributor
Author
There was a problem hiding this comment.
Absolutely @risicle; thank you for your suggestion.
I have also added an extra check to make sure we are cross-compiling.
20aa343 to
0bd67a1
Compare
0bd67a1 to
de4090d
Compare
de4090d to
e40905c
Compare
Member
|
Result of 296 packages marked as broken and skipped:
|
Member
|
No longer seems to be an issue on current master, and the package builds quick enough even without parallel building. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This issue is part of a series of bugfixes to improve the i686 cross-compilation pipeline.
Tracking issue: #195967
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes