apparmor: Remove flags not recognized by clang#195972
Closed
peperunas wants to merge 1 commit intoNixOS:stagingfrom
Closed
apparmor: Remove flags not recognized by clang#195972peperunas wants to merge 1 commit intoNixOS:stagingfrom
peperunas wants to merge 1 commit intoNixOS:stagingfrom
Conversation
Member
|
This has to target staging due to the mass rebuilds. |
ajs124
reviewed
Nov 3, 2022
| ''; | ||
|
|
||
| # -flto-partition=none is not recognized by Clang | ||
| preConfigure = if (stdenv.cc.isClang or false) then '' |
Member
There was a problem hiding this comment.
this can just use lib.optionalString. also, is the or false rellay necessary?
| ''; | ||
|
|
||
| # -flto-partition=none is not recognized by Clang | ||
| preConfigure = if (stdenv.cc.isClang or false) then '' |
Member
There was a problem hiding this comment.
Suggested change
| preConfigure = if (stdenv.cc.isClang or false) then '' | |
| preConfigure = lib.optionalString stdenv.cc.isClang '' |
Member
|
Closing as stale since the author did not react to feedback in years. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This issue is part of a series of bugfixes to improve the i686 cross-compilation pipeline.
Tracking issue: #195967
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes