audiofile: Don't pass '-lgcc' if using LLVM env#195971
Closed
peperunas wants to merge 1 commit intoNixOS:masterfrom
Closed
audiofile: Don't pass '-lgcc' if using LLVM env#195971peperunas wants to merge 1 commit intoNixOS:masterfrom
peperunas wants to merge 1 commit intoNixOS:masterfrom
Conversation
|
|
||
| # fix build with gcc9 | ||
| NIX_CFLAGS_LINK = lib.optional (stdenv.system == "i686-linux") "-lgcc"; | ||
| NIX_CFLAGS_LINK = lib.optional (stdenv.system == "i686-linux" && !(stdenv.hostPlatform.useLLVM or false)) "-lgcc"; |
Member
There was a problem hiding this comment.
I think you want to check stdenv.cc.isClang instead?
Contributor
Author
There was a problem hiding this comment.
I am not sure with Clang only; during my tests, I used a pure LLVM toolchain so I wouldn't be sure to check only for clang.
Member
There was a problem hiding this comment.
nix-repl> llvmPackages.stdenv.cc.isClang
true
Member
|
No longer passes lgcc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This issue is part of a series of bugfixes to improve the i686 cross-compilation pipeline.
Tracking issue: #195967
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes