Skip to content

libvorbis: Remove flags not recognized by clang#195968

Merged
3 commits merged intoNixOS:stagingfrom
peperunas:libvorbis-i686
Oct 15, 2022
Merged

libvorbis: Remove flags not recognized by clang#195968
3 commits merged intoNixOS:stagingfrom
peperunas:libvorbis-i686

Conversation

@peperunas
Copy link
Copy Markdown
Contributor

@peperunas peperunas commented Oct 14, 2022

Description of changes

This issue is part of a series of bugfixes to improve the i686 cross-compilation pipeline.

Tracking issue: #195967

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@peperunas peperunas mentioned this pull request Oct 14, 2022
Open
@ofborg ofborg bot requested a review from a user October 14, 2022 13:08
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 14, 2022
ghost
ghost reviewed Oct 14, 2022
View reviewed changes
pkgs/development/libraries/libvorbis/default.nix Outdated
Copy link
Copy Markdown

@ghost ghost Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be lib.optionalString (stdenv.cc.isClang or false) ''…''.

Copy link
Copy Markdown
Contributor Author

@peperunas peperunas Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@bobby285271 bobby285271 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 14, 2022
@ofborg ofborg bot requested a review from a user October 14, 2022 16:31
lovesegfault
lovesegfault reviewed Oct 14, 2022
View reviewed changes
lovesegfault
lovesegfault reviewed Oct 14, 2022
View reviewed changes
lovesegfault
lovesegfault reviewed Oct 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to target staging due to the mass rebuilds.

@peperunas peperunas changed the base branch from master to staging October 15, 2022 15:27
@peperunas peperunas requested review from a user and lovesegfault and removed request for a user and lovesegfault October 15, 2022 15:27
@ofborg ofborg bot requested a review from a user October 15, 2022 15:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peperunas @lovesegfault @bobby285271