Skip to content

nixos/installer: fix eval with missing config arg#195437

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
alyssais:installer-eval
Oct 11, 2022
Merged

nixos/installer: fix eval with missing config arg#195437
mweinelt merged 1 commit intoNixOS:masterfrom
alyssais:installer-eval

Conversation

@alyssais
Copy link
Copy Markdown
Member

@alyssais alyssais commented Oct 11, 2022

Fixes: 4cdda32 ("nixos/modules/profiles/base.nix: omit zfs if unavailable")

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@alyssais
nixos/installer: fix eval with missing config arg
d165f7a 
Fixes: 4cdda32 ("nixos/modules/profiles/base.nix: omit zfs if unavailable")
@alyssais alyssais added the 1.severity: channel blocker Blocks a channel label Oct 11, 2022
@alyssais alyssais requested a review from mweinelt October 11, 2022 00:01
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 11, 2022
@alyssais alyssais mentioned this pull request Oct 11, 2022
Merged
2 tasks
@alyssais
Copy link
Copy Markdown
Member Author

alyssais commented Oct 11, 2022

@ofborg test installer

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 11, 2022
@mweinelt mweinelt merged commit 2327ed0 into NixOS:master Oct 11, 2022
@ghost
Copy link
Copy Markdown

ghost commented Oct 12, 2022

Thank you for cleaning up the mess I made there.

@alyssais alyssais deleted the installer-eval branch October 16, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alyssais @mweinelt