Skip to content

elinks: use xorg.* packages directly instead of xlibsWrapper indirection#195222

Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom
trofi:elinks-without-xlibsWrapper
Oct 10, 2022
Merged

elinks: use xorg.* packages directly instead of xlibsWrapper indirection#195222
AndersonTorres merged 1 commit intoNixOS:masterfrom
trofi:elinks-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Oct 9, 2022 •
edited
Loading

Validated as no change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi trofi mentioned this pull request Oct 9, 2022
Closed
83 tasks
@ofborg ofborg bot requested review from gebner and iblech October 9, 2022 11:34
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 9, 2022
AndersonTorres
AndersonTorres reviewed Oct 9, 2022
View reviewed changes
@trofi
elinks: use libX11 directly instead of xlibsWrapper indirection
142aaff 
Validated as no change in `out` output with `diffoscope`.
@trofi trofi force-pushed the elinks-without-xlibsWrapper branch from 47d5601 to 142aaff Compare October 9, 2022 15:18
@trofi trofi requested a review from AndersonTorres October 9, 2022 15:19
@AndersonTorres AndersonTorres merged commit e1ffebe into NixOS:master Oct 10, 2022
@trofi trofi deleted the elinks-without-xlibsWrapper branch October 10, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gebner gebner Awaiting requested review from gebner

@iblech iblech Awaiting requested review from iblech

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @AndersonTorres