cudatoolkit: introduce 11.8.0 by dguibert · Pull Request #194705 · NixOS/nixpkgs

dguibert · 2022-10-06T05:57:17Z

Description of changes

Things done

dguibert · 2022-10-06T06:01:36Z

This PR also fix evaluation breakage of cudnn and tensorrt when the cudaVersion is not listed in any supported versions of those libraries. #192958 partially fixes the problem.

SuperSandro2000 · 2022-10-06T09:36:47Z

pkgs/development/libraries/science/math/cudnn/extension.nix

Can this use lib.versions.major/majorMinor?

yes, I'll change it for simplicity

SuperSandro2000 · 2022-10-06T09:37:18Z

pkgs/development/libraries/science/math/cudnn/extension.nix

Suggested change

else throw "cudnn-${cuDnnDefaultVersion} does not support your cuda version ${cudaVersion} (or update supportedCudaVersions)"; };

else throw "cudnn-${cuDnnDefaultVersion} does not support cuda ${cudaVersion}"; };

SuperSandro2000 · 2022-10-06T09:37:43Z

pkgs/development/libraries/science/math/tensorrt/extension.nix

Suggested change

else throw "tensorrt-${tensorRTDefaultVersion} does not support your cuda version ${cudaVersion} (or update supportedCudaVersions)"; };

else throw "tensorrt-${tensorRTDefaultVersion} does not support cuda ${cudaVersion}"; };

pkgs/test/cuda/cuda-samples/extension.nix

aidalgol · 2022-10-06T19:36:08Z

pkgs/top-level/all-packages.nix

Don't we want cudaPackages_11 to be an alias for the latest available version?

Yes, but as the current version of cudnn is not compatible with version 11.8 of cuda, I've not updated the alias.

If there is a consensus, no problem to update it

Ah, then yes, keep it back for now.

Latest cudnn is 8.6.0, compatible with cuda 11.8

(I'd do the bump in a separate commit, because everything else we can backport to 22.05)

Latest cudnn is 8.6.0, compatible with cuda 11.8

Thx, I'd missed that. Push an update in this PR.

samuela

Hey @dguibert, thanks for putting this together! Just adding a few comments here in addition to what others have already pointed out.

Btw, please don't forget https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md when writing commit messages. I believe cudatoolkit: 1.7.0 -> 1.7.1 should be cudatoolkit: 11.7.0 -> 11.7.1 for example.

pkgs/development/compilers/cudatoolkit/versions.toml

pkgs/test/cuda/cuda-samples/extension.nix

dguibert · 2022-10-07T11:44:40Z

@SomeoneSerge, I just saw your PR #194791. This one should be OK now to poke the jetson support.

pkgs/development/compilers/cudatoolkit/redist/extension.nix

Throw an error if the default version of tensorrt does not support the cuda version. Adding cudatoolkit 11.8 fails to evaluate tensorrt.{tensorRTDefaultVersion} as "11.8" is not listed on any supportedCudaVersions of any tensorRTVersions attributes.

samuela

LGTM i'll go ahead and merge tomorrow unless anyone objects

samuela · 2022-10-20T21:35:40Z

I'm now seeing build failures with cuDNN:

❯ nix-build -A cudaPackages.cudnn
these 2 derivations will be built:
  /nix/store/jr4j41x50wfjvm141x6gd4dnpf5gbj28-cudnn-linux-x86_64-8.6.0.163_cuda11-archive.tar.xz.drv
  /nix/store/jnn8s0baxw295hsvdxbbavpiqkyg50w9-cudatoolkit-11-cudnn-8.6.0.drv
building '/nix/store/jr4j41x50wfjvm141x6gd4dnpf5gbj28-cudnn-linux-x86_64-8.6.0.163_cuda11-archive.tar.xz.drv'...

trying https://developer.download.nvidia.com/compute/redist/cudnn/v8.6.0/local_installers/11.7/cudnn-linux-x86_64-8.6.0.163_cuda11-archive.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   445    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download cudnn-linux-x86_64-8.6.0.163_cuda11-archive.tar.xz from any mirror
error: builder for '/nix/store/jr4j41x50wfjvm141x6gd4dnpf5gbj28-cudnn-linux-x86_64-8.6.0.163_cuda11-archive.tar.xz.drv' failed with exit code 1;
       last 7 log lines:
       >
       > trying https://developer.download.nvidia.com/compute/redist/cudnn/v8.6.0/local_installers/11.7/cudnn-linux-x86_64-8.6.0.163_cuda11-archive.tar.xz
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0   445    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download cudnn-linux-x86_64-8.6.0.163_cuda11-archive.tar.xz from any mirror
       For full logs, run 'nix log /nix/store/jr4j41x50wfjvm141x6gd4dnpf5gbj28-cudnn-linux-x86_64-8.6.0.163_cuda11-archive.tar.xz.drv'.
error: 1 dependencies of derivation '/nix/store/jnn8s0baxw295hsvdxbbavpiqkyg50w9-cudatoolkit-11-cudnn-8.6.0.drv' failed to build

@dguibert could you take a look?

samuela · 2022-10-20T21:43:31Z

ok created #196983 to fix

dguibert requested review from aidalgol and samuela October 6, 2022 06:02

dguibert mentioned this pull request Oct 6, 2022

cudatoolkit: reintroduce version 11.7.0 to master #185557

Merged

13 tasks

dguibert force-pushed the dg/cudatoolkit_11_8_0 branch from a9c3365 to 84ac150 Compare October 6, 2022 06:06

ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 6, 2022

SuperSandro2000 reviewed Oct 6, 2022

View reviewed changes

aidalgol reviewed Oct 6, 2022

View reviewed changes

samuela mentioned this pull request Oct 6, 2022

cudaPackages_11_8: init, with support for jetsons #194791

Closed

2 tasks

SomeoneSerge added the 6.topic: cuda Parallel computing platform and API label Oct 6, 2022

samuela requested changes Oct 7, 2022

View reviewed changes

pkgs/development/compilers/cudatoolkit/versions.toml Outdated Show resolved Hide resolved

pkgs/test/cuda/cuda-samples/extension.nix Outdated Show resolved Hide resolved

dguibert force-pushed the dg/cudatoolkit_11_8_0 branch from 84ac150 to 342773d Compare October 7, 2022 11:35

dguibert requested review from FRidh and jonringer as code owners October 7, 2022 11:35

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 7, 2022

dguibert force-pushed the dg/cudatoolkit_11_8_0 branch from 342773d to ec5627d Compare October 7, 2022 11:38

github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 7, 2022

dguibert requested a review from samuela October 7, 2022 11:44

dguibert force-pushed the dg/cudatoolkit_11_8_0 branch from ec5627d to bbf4951 Compare October 7, 2022 11:45

samuela changed the title ~~cudatoolkit: introduce 1.8.0~~ cudatoolkit: introduce 11.8.0 Oct 8, 2022

dguibert force-pushed the dg/cudatoolkit_11_8_0 branch from bbf4951 to ec8c0aa Compare October 11, 2022 16:08

samuela reviewed Oct 13, 2022

View reviewed changes

pkgs/development/compilers/cudatoolkit/redist/extension.nix Show resolved Hide resolved

dguibert added 5 commits October 14, 2022 12:10

cudatookit: 11.8 + redistrib manifest

3eae0cc

cuddn: 8.5.0

6d0f92f

cuda-samples: 11.8 throw the non-existing tag

8a63fb0

cudnn: throw error if the default version is not supported

856e04d

cudnn: add 8.6.0, set default

af83b0c

dguibert force-pushed the dg/cudatoolkit_11_8_0 branch from ec8c0aa to af83b0c Compare October 14, 2022 10:10

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Oct 14, 2022

samuela approved these changes Oct 20, 2022

View reviewed changes

samuela merged commit 2fe7609 into NixOS:master Oct 20, 2022

samuela mentioned this pull request Oct 20, 2022

cudnn: fix 8.6.0 src url after upstream change #196983

Merged

13 tasks

SomeoneSerge mentioned this pull request Nov 9, 2022

cudaPackages_11_8: fix missing manifest #200426

Merged

	else throw "cudnn-${cuDnnDefaultVersion} does not support your cuda version ${cudaVersion} (or update supportedCudaVersions)"; };
	else throw "cudnn-${cuDnnDefaultVersion} does not support cuda ${cudaVersion}"; };

	else throw "tensorrt-${tensorRTDefaultVersion} does not support your cuda version ${cudaVersion} (or update supportedCudaVersions)"; };
	else throw "tensorrt-${tensorRTDefaultVersion} does not support cuda ${cudaVersion}"; };

Uh oh!

Conversation

dguibert commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

dguibert commented Oct 6, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samuela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dguibert commented Oct 7, 2022

Uh oh!

Uh oh!

samuela left a comment

Choose a reason for hiding this comment

Uh oh!

samuela commented Oct 20, 2022

Uh oh!

samuela commented Oct 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dguibert commented Oct 6, 2022 •

edited

Loading