Skip to content

x11_ssh_askpass use xorg.* packages directly instead of xlibsWrapper …#194492

Merged
trofi merged 1 commit intoNixOS:masterfrom
trofi:x11_ssh_askpass-without-xlibsWrapper
Oct 8, 2022
Merged

x11_ssh_askpass use xorg.* packages directly instead of xlibsWrapper …#194492
trofi merged 1 commit intoNixOS:masterfrom
trofi:x11_ssh_askpass-without-xlibsWrapper

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Oct 4, 2022 •
edited
Loading

…indirection

Validated as no change in out and man outputs with diffoscope on x11_ssh_askpass expression.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
x11_ssh_askpass use xorg.* packages directly instead of xlibsWrapper …
f3f06e7 
…indirection

Validated as no change in `out` and `man` outputs with diffoscope on
`x11_ssh_askpass` expression.
@trofi trofi mentioned this pull request Oct 4, 2022
Closed
83 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 4, 2022
@trofi trofi merged commit a07b881 into NixOS:master Oct 8, 2022
@trofi trofi deleted the x11_ssh_askpass-without-xlibsWrapper branch October 8, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@trofi